Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: warn about miss matched filter key #30882

Merged
merged 4 commits into from
Jun 9, 2021
Merged

fix: warn about miss matched filter key #30882

merged 4 commits into from
Jun 9, 2021

Conversation

wzhudev
Copy link
Contributor

@wzhudev wzhudev commented Jun 7, 2021

close #28107

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Table 增加内外部 filteredKeys 状态不一致的提示。
🇨🇳 Chinese Table adds warning when filteredKeys is controlled and not reflecting internal changes.

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2021

@codecov
Copy link

codecov bot commented Jun 7, 2021

Codecov Report

Merging #30882 (8e0308f) into master (b837ecd) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 8e0308f differs from pull request most recent head d5282c5. Consider uploading reports for the commit d5282c5 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##            master    #30882   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          397       397           
  Lines         7549      7555    +6     
  Branches      2123      2124    +1     
=========================================
+ Hits          7549      7555    +6     
Impacted Files Coverage Δ
components/table/hooks/useFilter/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b837ecd...d5282c5. Read the comment docs.

@afc163 afc163 merged commit 748be64 into ant-design:master Jun 9, 2021
devWarning(
filteredKeysIsNotControlled || filteredKeysIsAllControlled,
'Table',
'`FilteredKeys` should all be controlled or not controlled.',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

应该是 filteredKeys ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

合早了,感觉还要补一个测试用例。

@ycjcl868 ycjcl868 mentioned this pull request Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

filter not work while another filter using custom filterdropdown with react hooks
3 participants