-
-
Notifications
You must be signed in to change notification settings - Fork 50.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: warn about miss matched filter key #30882
Conversation
Codecov Report
@@ Coverage Diff @@
## master #30882 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 397 397
Lines 7549 7555 +6
Branches 2123 2124 +1
=========================================
+ Hits 7549 7555 +6
Continue to review full report at Codecov.
|
devWarning( | ||
filteredKeysIsNotControlled || filteredKeysIsAllControlled, | ||
'Table', | ||
'`FilteredKeys` should all be controlled or not controlled.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
应该是 filteredKeys
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
合早了,感觉还要补一个测试用例。
close #28107
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
filteredKeys
状态不一致的提示。filteredKeys
is controlled and not reflecting internal changes.☑️ Self Check before Merge