Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Form label hide title on help icon and optional text #31785

Merged
merged 1 commit into from
Aug 13, 2021

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Aug 13, 2021

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #31769

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Form shows title on help icon and optional text.
🇨🇳 Chinese 修复 Form 帮助图标和可选文案上有 title 提示的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Aug 13, 2021

@codecov
Copy link

codecov bot commented Aug 13, 2021

Codecov Report

Merging #31785 (a709f29) into master (ccf14fc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #31785   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          397       397           
  Lines         7591      7591           
  Branches      2078      2078           
=========================================
  Hits          7591      7591           
Impacted Files Coverage Δ
components/form/FormItemLabel.tsx 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccf14fc...a709f29. Read the comment docs.

@github-actions
Copy link
Contributor

Size Change: +4 B (0%)

Total Size: 833 kB

Filename Size Change
./dist/antd-with-locales.min.js 341 kB +2 B (0%)
./dist/antd.min.js 297 kB +2 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/antd.compact.min.css 64.4 kB
./dist/antd.dark.min.css 65.7 kB
./dist/antd.min.css 64.6 kB

compressed-size-action

@afc163 afc163 merged commit f0163aa into master Aug 13, 2021
@afc163 afc163 deleted the fix-form-label-help-title branch August 13, 2021 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form.Item tooltip: Besides the tooltip, sometimes it also shows the label title
1 participant