Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avatar group responsive font not working #34722

Merged

Conversation

laishiwen
Copy link
Contributor

@laishiwen laishiwen commented Mar 25, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fonts inside Avatar.Group components support responsive
🇨🇳 Chinese Avatar.Group 组件内的字体支持响应式

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@laishiwen
Copy link
Contributor Author

1、Avatar group font-size is invalid in responsive;
2、Font size inheritance private variable is more elegant;

@laishiwen
Copy link
Contributor Author

修复 Avatar.Group 设置属性 size={ xs: number, sm: number, ...} 在响应式中 Avatar 的字体大小不会跟随变化。

@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2022

@laishiwen
Copy link
Contributor Author

@zombieJ code review

@yoyo837 yoyo837 force-pushed the bugfix/avatar-group-responsive branch from 421e1ad to 4176f3e Compare June 16, 2022 15:42
@yoyo837
Copy link
Contributor

yoyo837 commented Jan 4, 2023

CI failed.

@argos-ci
Copy link

argos-ci bot commented Oct 2, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Oct 2, 2023, 10:43 PM

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (c4040ec) 100.00% compared to head (fe04d99) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #34722   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          681       681           
  Lines        11519     11519           
  Branches      3095      3095           
=========================================
  Hits         11519     11519           
Files Coverage Δ
components/avatar/avatar.tsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@li-jia-nan li-jia-nan merged commit 90d6377 into ant-design:master Oct 2, 2023
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants