-
-
Notifications
You must be signed in to change notification settings - Fork 50.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Table scroll shadow in rtl mode #40441
Merged
afc163
merged 3 commits into
ant-design:master
from
ds1371dani:bugfix/rtl_table_scroll_shadow
Jan 29, 2023
Merged
fix: Table scroll shadow in rtl mode #40441
afc163
merged 3 commits into
ant-design:master
from
ds1371dani:bugfix/rtl_table_scroll_shadow
Jan 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #40441 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 605 605
Lines 10306 10306
Branches 2774 2774
=========================================
Hits 10306 10306
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
CI failed. |
codeball-ai-writer
bot
added
codeball:needs-careful-review
and removed
codeball:needs-review
labels
Jan 29, 2023
afc163
reviewed
Jan 29, 2023
afc163
approved these changes
Jan 29, 2023
afc163
changed the title
FIX Table scroll shadow in rtl mode
fix: Table scroll shadow in rtl mode
Jan 29, 2023
20 tasks
RedJue
pushed a commit
to RedJue/ant-design
that referenced
this pull request
Apr 4, 2023
* 💄 STYLE: fix Table's scroll shadow in rtl mode * Revert "💄 STYLE: fix Table's scroll shadow in rtl mode" This reverts commit 06c9249. * 💄 STYLE: use logical properties
RedJue
pushed a commit
to RedJue/ant-design
that referenced
this pull request
Apr 25, 2023
* 💄 STYLE: fix Table's scroll shadow in rtl mode * Revert "💄 STYLE: fix Table's scroll shadow in rtl mode" This reverts commit 06c9249. * 💄 STYLE: use logical properties
RedJue
pushed a commit
to RedJue/ant-design
that referenced
this pull request
Apr 25, 2023
* 💄 STYLE: fix Table's scroll shadow in rtl mode * Revert "💄 STYLE: fix Table's scroll shadow in rtl mode" This reverts commit 06c9249. * 💄 STYLE: use logical properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
Table's vertical shadow in rtl mode is on the wrong side of the table.
📝 Changelog
☑️ Self-Check before Merge