fix(InputNumber): Fix incorrect disable state style for input box com… #42974
Conversation
…ponents with front and rear label configuration
|
|
|
|
|
InputNumber的props中， |
|
#42971 这样是否就足够了 |
|
我认为不太足够，我还原了他的PR代码，预览到的效果如下： 从图中的结果我发现 并且我认为
综上所述，这些问题我在我的PR中也是有考虑到并且都已经处理了。 |
|
来个测试用例吧 |
这里还是很奇怪，prefix 这里不应该有色差。 AAA 圆角左侧外围也有多余的 background。 |
是的，所以我的PR在style里面做了微小的调整来避免这些问题。 |
|
放一个 debug demo 来预览一下效果吧。 |
效果在这里的 @afc163 |
|
我想在 https://preview-42974-ant-design.surge.sh/ 这里直接看效果。 |
看你截图问题还在 |
…activation in the disabled state in InputNumber, and add corresponding test cases
我新增了对应 |
这里还是有色差的。 |
|
这里的色差是原本prefix的色差，就是可以看看这个案例 前缀配置 如果这个被认为是一个问题，我可以连同这个也一起修复了🔧 |
|
是个问题，这应该是个 bug。 |
…olor caused by the original prefix icon being disabled
我更新了，这是下面最新的预览效果。你也可以直接访问这里查看效果 addon禁用下案例 |
|
@afc163 我合并处理了你所指出的地方，并且移除了无效/重复的 |
|
snapshot 更新一下。 |
|
snapshot 还是有问题。 |
… adjusting the controls in the disabled state display
|
并没有修复，依然报错 
|
… adjusting the controls in the disabled state display
|
我看测试的快照好像又不通过😭，我看看啥回事 |
… adjusting the controls in the disabled state display
… adjusting the controls in the disabled state display
… adjusting the controls in the disabled state display
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #42974 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 648 648
Lines 10957 10957
Branches 2975 2975
=========================================
Hits 10957 10957
☔ View full report in Codecov by Sentry. |
|
终于好了👍🏻 |
非常感谢你帮我完成一次PR的体验，这个过程中我看了ant-design里相关的github工作流以及实践了ant-design的PR规范，学到了不少 |
|
恭喜成为 antd 贡献者~ |
ant-design#42974) * fix(InputNumber): Fix incorrect disable state style for input box components with front and rear label configuration * fix(InputNumber): Add case previews for pre and post tags and prefix activation in the disabled state in InputNumber, and add corresponding test cases * fix(InputNumber): Fix the issue of incorrect inputNumber background color caused by the original prefix icon being disabled * fix(InputNumber): Remove the toggle disable state interaction in the addon case * fix(InputNumber): Optimize and merge style processing * fix(InputNumber): Adjust the addon case and remove irrelevant cases * fix(InputNumber): Update the snapshot in the InputNumber component unit test * fix(InputNumber): Fix the issue of incorrect test snapshots caused by adjusting the controls in the disabled state display * fix(InputNumber): Fix the issue of incorrect test snapshots caused by adjusting the controls in the disabled state display * fix(InputNumber): Fix the issue of incorrect test snapshots caused by adjusting the controls in the disabled state display * fix(InputNumber): Fix the issue of incorrect test snapshots caused by adjusting the controls in the disabled state display * fix(InputNumber): Fix the issue of incorrect test snapshots caused by adjusting the controls in the disabled state display
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 2bb36f1
This pull request enhances the
InputNumbercomponent by fixing a bug with thecontrolsprop and improving the disabled styles. It modifiescomponents/input-number/index.tsxandcomponents/input-number/style/index.ts.🔍 Walkthrough
🤖 Generated by Copilot at 2bb36f1
controlsprop ofInputNumbercomponent was not converted to boolean, causing up and down buttons to disappear whencontrolswas false (link)InputNumbercomponent whendisabledprop is true, and apply disabled styles to wrapper and its children, such as cursor and background color (link, link, link)InputNumbercomponent that were already applied to input element (link)