Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type: pass-through cascader option generic type #43231

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

ZWkang
Copy link
Contributor

@ZWkang ZWkang commented Jun 27, 2023

[中文版模板 / Chinese template]

#43216

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English type: pass-through cascader option generic type
🇨🇳 Chinese type: 透传 cascader optionType 泛型

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 41c571f

Refactor cascader component to use rc-cascader and support custom option types. Change type parameters of cascader props to extend BaseOptionType.

🔍 Walkthrough

🤖 Generated by Copilot at 41c571f

  • Refactor cascader component to use rc-cascader package and improve performance and features (link, F0L250

@github-actions
Copy link
Contributor

github-actions bot commented Jun 27, 2023

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5df3097) 100.00% compared to head (41c571f) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #43231   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          648       648           
  Lines        10963     10963           
  Branches      2976      2976           
=========================================
  Hits         10963     10963           
Impacted Files Coverage Δ
components/cascader/index.tsx 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@afc163 afc163 merged commit f0059ce into ant-design:master Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants