Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: antd style at top #43847

Merged
merged 1 commit into from
Jul 27, 2023
Merged

enhance: antd style at top #43847

merged 1 commit into from
Jul 27, 2023

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jul 27, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English When using with other component libraries that use @ant-design/cssinjs, antd styles will always be inserted at the top to avoid style override issues caused by loading order.
🇨🇳 Chinese 和其他使用 @ant-design/cssinjs 的组件库混合使用,antd 的样式总是会插入在最前面,以避免加载顺序导致的样式覆盖问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at b0eb957

This pull request enhances the component style hook feature by adding an order property to the antd class name and updating the @ant-design/cssinjs dependency. These changes improve the compatibility and performance of the antd theme system.

🔍 Walkthrough

🤖 Generated by Copilot at b0eb957

  • Add order property to antd class name to ensure antd styles override other styles (link)
  • Upgrade @ant-design/cssinjs dependency to fix bug and improve performance of style hook (link)

@stackblitz
Copy link

stackblitz bot commented Jul 27, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2023

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 382.39 KB (+7 B 🔺)
./dist/antd-with-locales.min.js 441.95 KB (+5 B 🔺)

@argos-ci
Copy link

argos-ci bot commented Jul 27, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Jul 27, 2023, 7:31 AM

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (82090a1) 100.00% compared to head (b0eb957) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #43847   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          657       657           
  Lines        11075     11075           
  Branches      2996      2996           
=========================================
  Hits         11075     11075           
Files Changed Coverage Δ
components/theme/util/genComponentStyleHook.ts 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zombieJ zombieJ merged commit 6ff18d1 into master Jul 27, 2023
@zombieJ zombieJ deleted the order-style branch July 27, 2023 08:07
@vagusX vagusX mentioned this pull request Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants