Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Drawer support classNames #44935

Merged
merged 18 commits into from
Sep 25, 2023
Merged

feat: Drawer support classNames #44935

merged 18 commits into from
Sep 25, 2023

Conversation

kiner-tang
Copy link
Member

@kiner-tang kiner-tang commented Sep 18, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Drawer support classNames to customize build-in module's className
🇨🇳 Chinese 抽屉组件支持通过 classNames 自定义内置模块的 className

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 12e5a44

This pull request adds a new classNames prop to the Drawer and DrawerPanel components, which allows users to customize the className of the internal regions of the drawer. It also updates the documentation and the demo files for the drawer component in both English and Chinese languages. Additionally, it updates the rc-drawer dependency to the latest version.

🔍 Walkthrough

🤖 Generated by Copilot at 12e5a44

  • Add a new classNames prop to the Drawer and DrawerPanel components to allow users to customize the className of the internal regions of the drawer (link, link, link, link, link, link, link, link, link)
  • Update the rc-drawer dependency to the latest version that supports the classNames prop (link)
  • Add a new code example and documentation for the classNames prop in both Chinese and English languages in the demo and index files of the drawer component (link, link, link, link, link, link)

@stackblitz
Copy link

stackblitz bot commented Sep 18, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 18, 2023

@socket-security
Copy link

socket-security bot commented Sep 18, 2023

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
rc-drawer 6.5.2 None +0 59.2 kB madccc

@github-actions
Copy link
Contributor

github-actions bot commented Sep 18, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 396.77 KB (+236 B 🔺)
./dist/antd-with-locales.min.js 456.01 KB (+255 B 🔺)

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (ceed985) 100.00% compared to head (272aeb5) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #44935   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          687       687           
  Lines        11654     11655    +1     
  Branches      3119      3119           
=========================================
+ Hits         11654     11655    +1     
Files Changed Coverage Δ
components/config-provider/context.ts 100.00% <ø> (ø)
components/config-provider/index.tsx 100.00% <ø> (ø)
components/drawer/index.tsx 100.00% <ø> (ø)
components/drawer/DrawerPanel.tsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kiner-tang kiner-tang changed the title Drawer class names feat: Drawer support classNames Sep 20, 2023
@argos-ci
Copy link

argos-ci bot commented Sep 25, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Waiting for the first build to start…

components/drawer/index.tsx Outdated Show resolved Hide resolved
@MadCcc MadCcc merged commit 69d0487 into feature Sep 25, 2023
84 checks passed
@MadCcc MadCcc deleted the drawer-classNames branch September 25, 2023 12:37
| className | Drawer 容器外层 className 设置,如果需要设置最外层,请使用 rootClassName | string | - | |
| classNames | 配置抽屉内置模块的 className | `header?: string; body?: string; footer?: string; mask?: string; wrapper?: string;` | - | |
| styles | 配置抽屉内置模块的 style | `header?: CSSProperties; body?: CSSProperties; footer?: CSSProperties; mask?: CSSProperties; wrapper?: CSSProperties;` | - | 5.10.0 |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里是 wrapper,但是代码里是 content。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants