Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Autocomplete): internal input cannot apply fontFamily #45197

Merged
merged 1 commit into from
Oct 7, 2023

Conversation

Yuiai01
Copy link
Contributor

@Yuiai01 Yuiai01 commented Oct 7, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #45028

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Autocomplete internal input cannot apply fontFamily
🇨🇳 Chinese 修复 Autocomplete 内部 input 无法应用 fontFamily

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at df625e2

Fixed a bug where select component did not inherit font family in some scenarios. Refactored resetComponent function and moved it to components/style/index.ts for better code organization and reuse.

🔍 Walkthrough

🤖 Generated by Copilot at df625e2

  • Move resetComponent function from components/style/index.ts to components/select/style/single.tsx to avoid unnecessary imports and style conflicts (link)
  • Add needInheritFontFamily argument to resetComponent function to control font family inheritance for select component (link, link)

@stackblitz
Copy link

stackblitz bot commented Oct 7, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2023

@argos-ci
Copy link

argos-ci bot commented Oct 7, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Oct 7, 2023, 8:28 AM

@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (485e952) 100.00% compared to head (927ef7a) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #45197   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          681       681           
  Lines        11519     11522    +3     
  Branches      3095      3097    +2     
=========================================
+ Hits         11519     11522    +3     
Files Coverage Δ
components/select/style/single.tsx 100.00% <ø> (ø)
components/style/index.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MadCcc MadCcc merged commit f42d066 into ant-design:master Oct 7, 2023
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autocomplete input not reflecting fontFamily in theme configuration
4 participants