-
-
Notifications
You must be signed in to change notification settings - Fork 50.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ListField reset should not fill it #45284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run & review this pull request in StackBlitz Codeflow. |
crazyair
approved these changes
Oct 11, 2023
kiner-tang
approved these changes
Oct 11, 2023
li-jia-nan
approved these changes
Oct 11, 2023
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
size-limit report 📦
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #45284 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 693 692 -1
Lines 11842 11667 -175
Branches 3172 3117 -55
==========================================
- Hits 11842 11667 -175 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
fix #44861
💡 Background and solution
📝 Changelog
resetFields
will still keep Form.List field when itsinitialValue
is set.resetFields
时,无法重置配置了initialValue
的 Form.List 的问题。☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 4ea14ab
Updated
rc-field-form
dependency to fix aForm.Item
bug. This bug affected the behavior of thepreserve
prop, which controls whether to keep the field value and error after removing the field.🔍 Walkthrough
🤖 Generated by Copilot at 4ea14ab
rc-field-form
dependency to fix a bug related to thepreserve
prop of theForm.Item
component (link)