Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

demo: add tooltip disabled demo #45748

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Conversation

JarvisArt
Copy link
Contributor

@JarvisArt JarvisArt commented Nov 9, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English add Tooltip disabled demo
🇨🇳 Chinese 添加 Tooltip 禁用 demo

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at be64547

This pull request adds a new demo disabled-children.tsx to the tooltip component, which shows how to disable the tooltip for the wrapped children elements. It also updates the existing demo disabled.tsx and its documentation to clarify the difference between disabling the tooltip itself and disabling the tooltip for the wrapped children elements.

🔍 Walkthrough

🤖 Generated by Copilot at be64547

  • Add a new demo disabled-children.tsx and its documentation to show how to disable the tooltip for the wrapped children elements using the WrapperTooltip component (link, link, link, link)
  • Modify the existing demo disabled.tsx and its documentation to clarify that it shows how to disable the tooltip itself, not the wrapped children elements, and to simplify the code using a button and a span (link, link, link, link)

Copy link

stackblitz bot commented Nov 9, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Nov 9, 2023

Preview Is ready

Copy link

codesandbox-ci bot commented Nov 9, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bc0e91b:

Sandbox Source
antd reproduction template (forked) Configuration

Copy link

argos-ci bot commented Nov 9, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 1 change Nov 9, 2023, 6:45 AM

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8dc11ee) 100.00% compared to head (bc0e91b) 100.00%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #45748   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          700       700           
  Lines        11828     11828           
  Branches      3153      3153           
=========================================
  Hits         11828     11828           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -1,7 +1,7 @@
## zh-CN

Disabled 子元素。
禁用 Tooltip
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
禁用 Tooltip
通过设置 `title=""` 可以禁用 Tooltip


## en-US

Disabled Tooltip.
The Tooltip can be disabled by setting title="".
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The Tooltip can be disabled by setting title="".
The Tooltip can be disabled by setting `title=""`.


## en-US

Disabled Tooltip.
The Tooltip can be disabled by setting title="".
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The Tooltip can be disabled by setting title="".
The Tooltip can be disabled by setting `title=""`.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done~

@afc163 afc163 merged commit 5727ce0 into ant-design:master Nov 9, 2023
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants