Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Modal support aria-* in closable #47650

Merged
merged 6 commits into from
Mar 1, 2024

Conversation

kiner-tang
Copy link
Member

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English - Modal support aria-* in closable
- fix the issue in the demo where the p element covers the close button, resulting in invalid clicks
- Support document.activeElement
🇨🇳 Chinese - 弹框支持在 closable 中配置 aria-*
- 修复了演示中p元素覆盖关闭按钮导致无效点击的问题
- 支持 document.activeElement

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@kiner-tang kiner-tang requested review from zombieJ and MadCcc February 29, 2024 07:54
Copy link

stackblitz bot commented Feb 29, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Feb 29, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented Feb 29, 2024

👁 Visual Regression Report for PR #47650 Failed ❌

🎯 Target branch: feature (2156ed4)
📖 View Full Report ↗︎

Image name Expected Actual Diff
modal-render-panel.compact.png feature: 2156ed4c0739a150365241afc9977a8e881bed3a current: pr-47650 diff
modal-render-panel.compact.css-var.png feature: 2156ed4c0739a150365241afc9977a8e881bed3a current: pr-47650 diff
modal-render-panel.dark.png feature: 2156ed4c0739a150365241afc9977a8e881bed3a current: pr-47650 diff
modal-render-panel.dark.css-var.png feature: 2156ed4c0739a150365241afc9977a8e881bed3a current: pr-47650 diff
modal-render-panel.default.png feature: 2156ed4c0739a150365241afc9977a8e881bed3a current: pr-47650 diff
modal-render-panel.default.css-var.png feature: 2156ed4c0739a150365241afc9977a8e881bed3a current: pr-47650 diff

Check Full Report for details

Copy link
Contributor

github-actions bot commented Feb 29, 2024

size-limit report 📦

Path Size
./dist/antd.min.js 334.05 KB (-136 B 🔽)
./dist/antd-with-locales.min.js 379.91 KB (+83 B 🔺)

Copy link

socket-security bot commented Feb 29, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@fortawesome/fontawesome-common-types@6.5.1, npm/@fortawesome/free-regular-svg-icons@6.5.1, npm/@fortawesome/free-solid-svg-icons@6.5.1, npm/@swc/core@1.3.72, npm/esbuild@0.18.20

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

Copy link

codesandbox-ci bot commented Feb 29, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@yoyo837
Copy link
Contributor

yoyo837 commented Feb 29, 2024

@SocketSecurity ignore npm/esbuild@0.18.20
@SocketSecurity ignore npm/@swc/core@1.3.72
@SocketSecurity ignore npm/@fortawesome/fontawesome-common-types@6.5.1
@SocketSecurity ignore npm/@fortawesome/free-regular-svg-icons@6.5.1
@SocketSecurity ignore npm/@fortawesome/free-solid-svg-icons@6.5.1

1 similar comment
@kiner-tang
Copy link
Member Author

@SocketSecurity ignore npm/esbuild@0.18.20
@SocketSecurity ignore npm/@swc/core@1.3.72
@SocketSecurity ignore npm/@fortawesome/fontawesome-common-types@6.5.1
@SocketSecurity ignore npm/@fortawesome/free-regular-svg-icons@6.5.1
@SocketSecurity ignore npm/@fortawesome/free-solid-svg-icons@6.5.1

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/chalk@4.1.2, npm/cheerio@1.0.0-rc.12, npm/circular-dependency-plugin@5.2.2, npm/classnames@2.5.1, npm/copy-to-clipboard@3.3.3, npm/cross-env@7.0.3, npm/cross-fetch@4.0.0, npm/crypto@1.0.1, npm/dayjs@1.11.10, npm/dekko@0.2.1, npm/dumi-plugin-color-chunk@1.1.0, npm/dumi@2.3.0-beta.7, npm/esbuild-loader@4.0.3, npm/eslint-config-airbnb@19.0.4, npm/eslint-config-prettier@9.1.0, npm/eslint-import-resolver-typescript@3.6.1, npm/eslint-plugin-compat@4.2.0, npm/eslint-plugin-import@2.29.1, npm/eslint-plugin-jest@27.9.0, npm/eslint-plugin-jsx-a11y@6.8.0, npm/eslint-plugin-lodash@7.4.0, npm/eslint-plugin-markdown@3.0.1, npm/eslint-plugin-react-hooks@4.6.0, npm/eslint-plugin-react@7.33.2, npm/eslint-plugin-unicorn@51.0.1, npm/eslint@8.57.0, npm/fast-glob@3.3.2, npm/fetch-jsonp@1.3.0, npm/fs-extra@11.2.0, npm/gh-pages@6.1.1, npm/glob@10.3.10, npm/html2sketch@1.0.2, npm/http-server@14.1.1, npm/husky@9.0.11, npm/identity-obj-proxy@3.0.0, npm/immer@10.0.3, npm/inquirer@9.2.15, npm/is-ci@3.0.1, npm/isomorphic-fetch@3.0.0, npm/jest-axe@8.0.0, npm/jest-canvas-mock@2.5.2, npm/jest-environment-jsdom@29.7.0, npm/jest-environment-node@29.7.0, npm/jest-image-snapshot@6.4.0, npm/jest-puppeteer@10.0.1, npm/jest@29.7.0, npm/jquery@3.7.1, npm/jsdom@24.0.0, npm/jsonml-to-react-element@1.1.11, npm/jsonml.js@0.1.0, npm/lint-staged@15.2.2, npm/lodash@4.17.21, npm/lunar-typescript@1.7.3, npm/lz-string@1.5.0, npm/minimist@1.2.8, npm/mockdate@3.0.5, npm/node-fetch@3.3.2, npm/node-notifier@10.0.1, npm/nprogress@0.2.0, npm/open@10.0.4, npm/pixelmatch@5.3.0, npm/pngjs@7.0.0, npm/prettier-plugin-jsdoc@1.3.0, npm/prettier@3.2.5, npm/pretty-format@29.7.0, npm/prismjs@1.29.0, npm/progress@2.0.3, npm/puppeteer@22.3.0, npm/qrcode.react@3.1.0, npm/qs@6.11.2, npm/rc-cascader@3.21.2, npm/rc-checkbox@3.1.0, npm/rc-collapse@3.7.2, npm/rc-dialog@9.3.4, npm/rc-drawer@7.1.0, npm/rc-dropdown@4.1.0, npm/rc-field-form@1.41.0, npm/rc-footer@0.6.8, npm/rc-image@7.5.1, npm/rc-input-number@9.0.0, npm/rc-input@1.4.3, npm/rc-mentions@2.10.1, npm/rc-menu@9.12.4, npm/rc-motion@2.9.0, npm/rc-notification@5.3.0, npm/rc-pagination@4.0.4, npm/rc-picker@4.1.5, npm/rc-progress@3.5.1, npm/rc-rate@2.12.0, npm/rc-resize-observer@1.4.0, npm/rc-segmented@2.3.0, npm/rc-select@14.11.0, npm/rc-slider@10.5.0, npm/rc-steps@6.0.1, npm/rc-switch@4.1.0, npm/rc-table@7.42.0, npm/rc-tabs@14.0.0, npm/rc-textarea@1.6.3, npm/rc-tooltip@6.1.3, npm/rc-tree-select@5.17.0, npm/rc-tree@5.8.5, npm/rc-tween-one@3.0.6, npm/rc-upload@4.5.2, npm/rc-util@5.38.2, npm/rc-virtual-list@3.11.4, npm/react-copy-to-clipboard@5.1.0, npm/react-countup@6.5.0, npm/react-dom@18.2.0, npm/react-draggable@4.4.6, npm/react-fast-marquee@1.6.4, npm/react-highlight-words@0.20.0, npm/react-infinite-scroll-component@6.1.0, npm/react-intersection-observer@9.8.1, npm/react-resizable@3.0.5, npm/react-sticky-box@2.0.5, npm/react@18.2.0, npm/regenerator-runtime@0.14.1, npm/remark-cli@12.0.0, npm/remark-gfm@4.0.0, npm/remark-html@16.0.1, npm/remark-lint-no-undefined-references@4.2.1, npm/remark-lint@9.1.2, npm/remark-preset-lint-recommended@6.1.3, npm/remark@15.0.1, npm/runes2@1.1.4, npm/scroll-into-view-if-needed@3.1.0, npm/sharp@0.33.2, npm/simple-git@3.22.0, npm/size-limit@11.0.2, npm/stylelint-config-rational-order@0.1.2, npm/stylelint-config-standard@36.0.0, npm/stylelint-prettier@5.0.0, npm/stylelint@16.2.1, npm/throttle-debounce@5.0.0

View full report↗︎

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (183746a) to head (de74a15).
Report is 1 commits behind head on feature.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #47650   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          736       736           
  Lines        12637     12637           
  Branches      3323      3323           
=========================================
  Hits         12637     12637           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kiner-tang kiner-tang merged commit 6928fbc into feature Mar 1, 2024
104 of 105 checks passed
@kiner-tang kiner-tang deleted the feature-aria-in-closable-Modal branch March 1, 2024 02:58
Copy link
Contributor

github-actions bot commented Mar 1, 2024

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

@@ -254,19 +254,24 @@ exports[`Image Default Group preview props 1`] = `
tabindex="0"
/>
<div
class="ant-image-preview-content"
style="outline: none;"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为什么这里要把 content 往里挪一层

@@ -132,11 +132,11 @@
"rc-cascader": "~3.21.2",
"rc-checkbox": "~3.1.0",
"rc-collapse": "~3.7.2",
"rc-dialog": "~9.3.4",
"rc-dialog": "~9.4.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wahiche-ideal This is what you are looking for.

tanzhenyun pushed a commit to DraculaPrince/mark15 that referenced this pull request Mar 29, 2024
* feat: Modal support aria-* in closable

* feat: Modal support aria-* in closable

* feat: Modal support aria-* in closable

* chore: bump rc-image

* feat: update snap

* feat: update snap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants