-
-
Notifications
You must be signed in to change notification settings - Fork 50.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Modal support aria-* in closable #47650
Conversation
Run & review this pull request in StackBlitz Codeflow. |
👁 Visual Regression Report for PR #47650 Failed ❌
Check Full Report for details |
size-limit report 📦
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
@SocketSecurity ignore npm/esbuild@0.18.20 |
1 similar comment
@SocketSecurity ignore npm/esbuild@0.18.20 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature #47650 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 736 736
Lines 12637 12637
Branches 3323 3323
=========================================
Hits 12637 12637 ☔ View full report in Codecov by Sentry. |
@@ -254,19 +254,24 @@ exports[`Image Default Group preview props 1`] = ` | |||
tabindex="0" | |||
/> | |||
<div | |||
class="ant-image-preview-content" | |||
style="outline: none;" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
为什么这里要把 content 往里挪一层
@@ -132,11 +132,11 @@ | |||
"rc-cascader": "~3.21.2", | |||
"rc-checkbox": "~3.1.0", | |||
"rc-collapse": "~3.7.2", | |||
"rc-dialog": "~9.3.4", | |||
"rc-dialog": "~9.4.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wahiche-ideal This is what you are looking for.
* feat: Modal support aria-* in closable * feat: Modal support aria-* in closable * feat: Modal support aria-* in closable * chore: bump rc-image * feat: update snap * feat: update snap
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
- fix the issue in the demo where the p element covers the close button, resulting in invalid clicks
- Support document.activeElement
- 修复了演示中p元素覆盖关闭按钮导致无效点击的问题
- 支持 document.activeElement
☑️ Self-Check before Merge