Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: unify Modal and Drawer close icon style #47909

Merged
merged 6 commits into from
Mar 16, 2024
Merged

style: unify Modal and Drawer close icon style #47909

merged 6 commits into from
Mar 16, 2024

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Mar 16, 2024 •
edited
Loading

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #47890

💡 Background and solution

图片

📝 Changelog

Language Changelog
🇺🇸 English Unify Modal, Drawer, Tour and notification close button style.
🇨🇳 Chinese 统一 Modal、Drawer、Tour、notification 关闭按钮的样式，增大关闭按钮的操作区域使其更容易点击。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@stackblitz StackBlitz
Copy link

stackblitz bot commented Mar 16, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 16, 2024 •
edited
Loading

👁 Visual Regression Report for PR #47909 Failed ❌

🎯 Target branch: master (96bade2)
📖 View Full Report ↗︎

Image name Expected Actual Diff
drawer-component-token.compact.png master: 96bade2dada4643b07051880a9bc24d9e3d4335d current: pr-47909 diff
drawer-component-token.compact.css-var.png master: 96bade2dada4643b07051880a9bc24d9e3d4335d current: pr-47909 diff
drawer-component-token.dark.png master: 96bade2dada4643b07051880a9bc24d9e3d4335d current: pr-47909 diff
drawer-component-token.dark.css-var.png master: 96bade2dada4643b07051880a9bc24d9e3d4335d current: pr-47909 diff
drawer-component-token.default.png master: 96bade2dada4643b07051880a9bc24d9e3d4335d current: pr-47909 diff
drawer-component-token.default.css-var.png master: 96bade2dada4643b07051880a9bc24d9e3d4335d current: pr-47909 diff
drawer-render-panel.compact.png master: 96bade2dada4643b07051880a9bc24d9e3d4335d current: pr-47909 diff
drawer-render-panel.compact.css-var.png master: 96bade2dada4643b07051880a9bc24d9e3d4335d current: pr-47909 diff
drawer-render-panel.dark.png master: 96bade2dada4643b07051880a9bc24d9e3d4335d current: pr-47909 diff
drawer-render-panel.dark.css-var.png master: 96bade2dada4643b07051880a9bc24d9e3d4335d current: pr-47909 diff

Check Full Report for details

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 16, 2024 •
edited
Loading

Preview is ready

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 16, 2024 •
edited
Loading

size-limit report 📦

Path Size
./dist/antd.min.js 334.79 KB (+145 B 🔺)
./dist/antd-with-locales.min.js 380.52 KB (+84 B 🔺)

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Mar 16, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@afc163 afc163 mentioned this pull request Mar 16, 2024
Closed
20 tasks
@codecov Codecov
Copy link

codecov bot commented Mar 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (96bade2) to head (f00864b).

Additional details and impacted files 
@@            Coverage Diff            @@
##            master    #47909   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          736       736           
  Lines        12670     12664    -6     
  Branches      3330      3325    -5     
=========================================
- Hits         12670     12664    -6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

li-jia-nan
li-jia-nan previously approved these changes Mar 16, 2024
View reviewed changes
@afc163 afc163 force-pushed the style/modal-drawer-close-icon-style branch from ae722da to c7e9c80 Compare March 16, 2024 12:53
crazyair
crazyair previously approved these changes Mar 16, 2024
View reviewed changes
@afc163 afc163 mentioned this pull request Mar 16, 2024
Merged
li-jia-nan
li-jia-nan previously approved these changes Mar 16, 2024
View reviewed changes
@afc163 afc163 force-pushed the style/modal-drawer-close-icon-style branch from f86e986 to d51ae65 Compare March 16, 2024 14:19
@afc163
Copy link
Member Author

afc163 commented Mar 16, 2024

Virsual Diff 的内容混掉了，真正的 diff 在这里 https://antd-visual-diff.oss-cn-shanghai.aliyuncs.com/pr-47909/visualRegressionReport/report.html

@afc163 afc163 merged commit e8839ae into master Mar 16, 2024
105 of 106 checks passed
@afc163 afc163 deleted the style/modal-drawer-close-icon-style branch March 16, 2024 15:21
@github-actions GitHub Actions
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献！如果您还没有加入钉钉社区群，请扫描下方二维码加入我们（加群时请提供此 PR 链接）。

@crazyair
Copy link
Member

我是把diff评论删了，重新提个空提交

tanzhenyun pushed a commit to DraculaPrince/mark15 that referenced this pull request Mar 29, 2024
@afc163
style: unify Modal and Drawer close icon style (ant-design#47909)
672d748 
* style: unify Modal and Drawer close icon style

* style: fix Drawer close icon style

* style: add focus style

* style: unify close btn style

* test: update snapshots

* style: tweak drawer close icon size
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazyair crazyair crazyair left review comments

@yoyo837 yoyo837 yoyo837 left review comments

@li-jia-nan li-jia-nan li-jia-nan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modal 关闭按钮可点击区域比较小
4 participants
@afc163 @crazyair @yoyo837 @li-jia-nan