-
-
Notifications
You must be signed in to change notification settings - Fork 50.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Checkbox): indeterminate state #51350
fix(Checkbox): indeterminate state #51350
Conversation
Run & review this pull request in StackBlitz Codeflow. |
๐ Visual Regression Report for PR #51350 Failed โ
Check Full Report for details If you think the visual diff is acceptable, please check:
|
WalkthroughThis pull request addresses a bug in the Checkbox component where the Changes
|
More templates
commit: |
1d7226e
to
af863a4
Compare
Codecov ReportAll modified and coverable lines are covered by tests โ
Additional details and impacted files@@ Coverage Diff @@
## master #51350 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 761 761
Lines 13495 13499 +4
Branches 3507 3507
=========================================
+ Hits 13495 13499 +4 โ View full report in Codecov by Sentry. |
The visual diffs in this PR are not a result of my changes. I've noticed the same diffs in another PR #51351 (comment) |
@SpaNb4 You're awesome. ๐ค๐ค |
๐ค This is a ...
๐ Related Issues
๐ก Background and Solution
Checkbox component previously incorrectly set the
aria-checked
attribute for its indeterminate state, causing accessibility issues. This solution ensures proper use of theindeterminate
attribute in the component's logic and includes tests to verify its correct behavior๐ Change Log