Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Table): improve the order of merging inline styles in table header column #51793

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

Wxh16144
Copy link
Member

@Wxh16144 Wxh16144 commented Nov 27, 2024

中文版模板 / Chinese template

🤔 This is a ...

  • 🆕 New feature
  • 🐞 Bug fix
  • 📝 Site / documentation improvement
  • 📽️ Demo improvement
  • 💄 Component style improvement
  • 🤖 TypeScript definition improvement
  • 📦 Bundle size optimization
  • ⚡️ Performance optimization
  • ⭐️ Feature enhancement
  • 🌐 Internationalization
  • 🛠 Refactoring
  • 🎨 Code style optimization
  • ✅ Test Case
  • 🔀 Branch merge
  • ⏩ Workflow
  • ❓ Other (about what?)

🔗 Related Issues

resolve #51763

  • Describe the source of related requirements, such as links to relevant issue discussions.
  • For example: close #xxxx, fix #xxxx

💡 Background and Solution

  • The specific problem to be addressed.
  • List the final API implementation and usage if needed.
  • If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Language Changelog
🇺🇸 English improve the order of merging inline styles in table header column
🇨🇳 Chinese 升级 rc-table, 改进 table header column 内联样式合并顺序

Update package.json

resolve #51763

Signed-off-by: 𝑾𝒖𝒙𝒉 <wxh1220@gmail.com>
Copy link

stackblitz bot commented Nov 27, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Nov 27, 2024

👁 Visual Regression Report for PR #51793 Passed ✅

🎯 Target branch: master (631e501)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

Copy link
Contributor

github-actions bot commented Nov 27, 2024

Preview is ready

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/rc-table@7.49.0 None 0 402 kB afc163, benjycui, dxq613, ...6 more

🚮 Removed packages: npm/rc-table@7.48.1

View full report↗︎

Copy link
Contributor

size-limit report 📦

Path Size
dist/antd.min.js 441.43 KB (+1 B 🔺)
dist/antd-with-locales.min.js 509.36 KB (+1 B 🔺)

Copy link

codecov bot commented Nov 27, 2024

Bundle Report

Changes will decrease total bundle size by 50 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
antd.min-array-push 3.37MB 50 bytes (-0.0%) ⬇️

Copy link

pkg-pr-new bot commented Nov 27, 2024

@zombieJ
Copy link
Member

zombieJ commented Nov 27, 2024

写一下 changelog

Copy link

Deploying ant-design with  Cloudflare Pages  Cloudflare Pages

Latest commit: a6bb0e9
Status: ✅  Deploy successful!
Preview URL: https://a101c274.ant-design.pages.dev
Branch Preview URL: https://wxh16144-patch-1.ant-design.pages.dev

View logs

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (631e501) to head (a6bb0e9).
Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #51793   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          761       761           
  Lines        13555     13555           
  Branches      3537      3537           
=========================================
  Hits         13555     13555           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163
Copy link
Member

afc163 commented Nov 27, 2024

changelog 写一下?

@Wxh16144
Copy link
Member Author

changelog 写一下?

ready~,合并的时候看看 title 是否需要改一下 type. 方便 changelog 体现

@afc163
Copy link
Member

afc163 commented Nov 28, 2024

@Wxh16144 Wxh16144 changed the title chore(deps): bump rc-table to 7.49.0 feat(Table): improve the order of merging inline styles in table header column Nov 28, 2024
@afc163
Copy link
Member

afc163 commented Nov 29, 2024

feat 还是 fix?看上去不是新特性?

@Wxh16144 Wxh16144 changed the title feat(Table): improve the order of merging inline styles in table header column fix(Table): improve the order of merging inline styles in table header column Nov 29, 2024
@Wxh16144
Copy link
Member Author

feat 还是 fix?看上去不是新特性?

fix 吧,改了合并顺序

@afc163 afc163 merged commit e1d8587 into master Nov 29, 2024
77 checks passed
@afc163 afc163 deleted the Wxh16144-patch-1 branch November 29, 2024 12:58
@PeachScript PeachScript mentioned this pull request Dec 2, 2024
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table columns 支持设置 header column 的 align
3 participants