Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: resolve missing component tokens #52406

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

coding-ice
Copy link
Member

中文版模板 / Chinese template

🤔 This is a ...

  • 🆕 New feature
  • 🐞 Bug fix
  • 📝 Site / documentation improvement
  • 📽️ Demo improvement
  • 💄 Component style improvement
  • 🤖 TypeScript definition improvement
  • 📦 Bundle size optimization
  • ⚡️ Performance optimization
  • ⭐️ Feature enhancement
  • 🌐 Internationalization
  • 🛠 Refactoring
  • 🎨 Code style optimization
  • ✅ Test Case
  • 🔀 Branch merge
  • ⏩ Workflow
  • ❓ Other (about what?)

🔗 Related Issues

  • Describe the source of related requirements, such as links to relevant issue discussions.
  • For example: close #xxxx, fix #xxxx

💡 Background and Solution

  • The specific problem to be addressed.
  • List the final API implementation and usage if needed.
  • If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Language Changelog
🇺🇸 English fix missing component tokens
🇨🇳 Chinese 修复缺失的组件 token

Copy link

stackblitz bot commented Jan 15, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Jan 15, 2025

Preview is ready

Copy link
Contributor

github-actions bot commented Jan 15, 2025

👁 Visual Regression Report for PR #52406 Failed ❌

🎯 Target branch: master (1ccda5f)
📖 View Full Report ↗︎
📊 Summary: 🔄 3 changed

Expected (Branch master) Actual (Current PR) Diff
input-group.compact.png input-group.compact.png input-group.compact.css-var.png input-group.compact.css-var.png
list-vertical.dark.png list-vertical.dark.png list-vertical.dark.png list-vertical.dark.png
list-vertical.dark.png list-vertical.dark.png list-vertical.dark.css-var.png list-vertical.dark.css-var.png

Important

There are 3 diffs found in this PR: 🔄 3 changed.
Please check all items:

  • Visual diff is acceptable

Copy link

Walkthrough

This pull request focuses on improving the documentation by resolving missing component tokens. The changes involve modifying the ComponentToken type to an interface in two files, which enhances the clarity and structure of the documentation.

Changes

Files Summary
components/rate/style/index.ts, components/skeleton/style/index.ts Changed ComponentToken from a type to an interface to improve documentation clarity.

@@ -5,7 +5,7 @@ import { resetComponent } from '../../style';
import type { FullToken, GenerateStyle, GetDefaultToken } from '../../theme/internal';
import { genStyleHooks, mergeToken } from '../../theme/internal';

export type ComponentToken = {
export interface ComponentToken {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed ComponentToken from a type to an interface to improve documentation clarity.

@@ -4,7 +4,7 @@ import { Keyframes, unit } from '@ant-design/cssinjs';
import type { CSSUtil, FullToken, GenerateStyle, GetDefaultToken } from '../../theme/internal';
import { genStyleHooks, mergeToken } from '../../theme/internal';

export type ComponentToken = {
export interface ComponentToken {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed ComponentToken from a type to an interface to improve documentation clarity.

Copy link

pkg-pr-new bot commented Jan 15, 2025

Copy link

codecov bot commented Jan 15, 2025

Bundle Report

Bundle size has no change ✅

@coding-ice coding-ice merged commit 8734fdf into ant-design:master Jan 15, 2025
38 of 39 checks passed
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (1ccda5f) to head (0c527c9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #52406   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          763       763           
  Lines        13775     13774    -1     
  Branches      3605      3604    -1     
=========================================
- Hits         13775     13774    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants