Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move filterOption to AbstractSelectProps in Select Component #5393

Merged
merged 1 commit into from
Mar 20, 2017

Conversation

mitchelldemler
Copy link

Currently the Autocomplete component breaks in Typescript when calling filterOption.

Autocomplete props extend AbstractSelectProps, but filterOption is only available in SelectProps. I have just rearranged so both components can use filterOption.

@mention-bot
Copy link

@mitchelldemler, thanks for your PR! By analyzing the history of the files in this pull request, we identified @benjycui, @afc163 and @infeng to be potential reviewers.

@codecov
Copy link

codecov bot commented Mar 20, 2017

Codecov Report

Merging #5393 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5393   +/-   ##
=======================================
  Coverage   82.58%   82.58%           
=======================================
  Files         166      166           
  Lines        4394     4394           
  Branches     1274     1274           
=======================================
  Hits         3629     3629           
  Misses        765      765
Impacted Files Coverage Δ
components/select/index.tsx 90.9% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35ab3fb...5b94d3c. Read the comment docs.

@benjycui benjycui merged commit e968b57 into ant-design:master Mar 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants