core: Remove unexpected error and related unnecessary casting #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unexpected error was a hack to handle items that would otherwise panic in xdvdfs-web (as it can't catch panics). The lint is failing on nightly because it's unused if write is not enabled, which is a great reminder to remove it. The majority of the unexpected errors are to handle overflow when casting down to lower sized integer types, so this commit refactors the code to remove most of these casts in the first place. The remaining ones are just allowed to panic (and I don't expect it's likely they'll be run into anyway).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unexpected error was a hack to handle items that would otherwise panic
in xdvdfs-web (as it can't catch panics). The lint is failing on nightly
because it's unused if write is not enabled, which is a great reminder
to remove it.
The majority of the unexpected errors are to handle overflow when
casting down to lower sized integer types, so this commit refactors the
code to remove most of these casts in the first place. The remaining ones
are just allowed to panic (and I don't expect it's likely they'll be run
into anyway).