Testing clang-format CI #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antangelo
force-pushed
the
ci/clang-format-test
branch
3 times, most recently
from
4dfe402 to
d29e9b9
Compare
Cpp-Linter Report
|
antangelo
force-pushed
the
ci/clang-format-test
branch
from
d29e9b9 to
fe87575
Compare
antangelo
force-pushed
the
ci/clang-format-test
branch
from
fe87575 to
e950282
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cpp-linter Review
Used clang-format v16.0.6
Click here for the full clang-format patch
diff --git a/softmmu/vl.c b/softmmu/vl.c
index 447eee7..5582986 100644
--- a/softmmu/vl.c
+++ b/softmmu/vl.c
@@ -2820 +2820,2 @@ void qemu_init(int argc, char **argv)
- } if (g_config.general.show_welcome) {
+ }
+ if (g_config.general.show_welcome) {
@@ -2835 +2836 @@ void qemu_init(int argc, char **argv)
- fake_argv[fake_argc++] = strdup("-m");
+ fake_argv[fake_argc++] = strdup("-m");
Have any feedback or feature suggestions? Share it here.
|
|
||
| if (flashrom_override_path) { | ||
| assert(!xemu_check_file(flashrom_override_path)); | ||
| } if (g_config.general.show_welcome) { |
There was a problem hiding this comment.
clang-format suggestion
Suggested change
| } if (g_config.general.show_welcome) { | |
| } | |
| if (g_config.general.show_welcome) { |
| @@ -2820,7 +2832,7 @@ | |||
| } | |||
|
|
|||
| int mem = ((int)g_config.sys.mem_limit + 1) * 64; | |||
| fake_argv[fake_argc++] = strdup("-m"); | |||
| fake_argv[fake_argc++] = strdup("-m"); | |||
There was a problem hiding this comment.
clang-format suggestion
Suggested change
| fake_argv[fake_argc++] = strdup("-m"); | |
| fake_argv[fake_argc++] = strdup("-m"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.