-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fails with Node.js v18.1.0 #81
Comments
Looks like this is an issue of emscripten References |
I've sent a patch to the emscripten: emscripten-core/emscripten#16917 |
This was referenced May 8, 2022
sounisi5011
added a commit
to sounisi5011/npm-packages
that referenced
this issue
May 28, 2022
`argon2-browser` fails with Node.js 18. Because of this, `@sounisi5011/encrypted-archive` cannot support Node.js 18 yet. see antelle/argon2-browser#81
sounisi5011
added a commit
to sounisi5011/npm-packages
that referenced
this issue
May 28, 2022
* fix(node): support Node.js v18+ * test(check-pid-file): change timeout for test case "remove pid file on finish" from 5000ms to 15000ms In Node.js 18, SIGQUIT tests now take more than 5000ms. * test(encrypted-archive): change timeout from 5000ms to 15000ms In Node.js 18, some tests now take more than 5000ms. * revert: test(encrypted-archive): change timeout from 5000ms to 15000ms This reverts commit 30456ec. * fix(encrypted-archive): not yet able to support Node.js 18 `argon2-browser` fails with Node.js 18. Because of this, `@sounisi5011/encrypted-archive` cannot support Node.js 18 yet. see antelle/argon2-browser#81
sounisi5011
added a commit
to sounisi5011/npm-packages
that referenced
this issue
May 28, 2022
argon2-browser does not work with Node.js 18. see antelle/argon2-browser#81 Note: Do not update `argon2`. from `argon2@0.28` we cannot specify less memory size (Maximum "2048" from `0.28.0 - 0.28.2`, maximum "1024" from `>=0.28.3`). The argon2 library must be able to specify a minimum memory size of "8" due to loss of backward compatibility.
sounisi5011
added a commit
to sounisi5011/npm-packages
that referenced
this issue
May 28, 2022
* fix(encrypted-archive): support Node.js v18+ * fix(encrypted-archive): replace `argon2-browser` with `argon2` argon2-browser does not work with Node.js 18. see antelle/argon2-browser#81 Note: Do not update `argon2`. from `argon2@0.28` we cannot specify less memory size (Maximum "2048" from `0.28.0 - 0.28.2`, maximum "1024" from `>=0.28.3`). The argon2 library must be able to specify a minimum memory size of "8" due to loss of backward compatibility. * test(encrypted-archive): fix test cases that use internal errors in the argon2 library * test(encrypted-archive): run test cases using internal errors in the argon2 library only on CI * fix(encrypted-archive): use node-argon2 only with Node.js 18.1.0 or later This PR is just a patch. For older versions of Node.js that we have supported so far, we will still use `argon2-browser`. * refactor(encrypted-archive): reduce lines in `argon2Hash()` function Code Climate reported: + Function `argon2Hash` has 39 lines of code (exceeds 25 allowed). Consider refactoring. * refactor(encrypted-archive): reduce lines in `src/key-derivation-function/argon2.ts` file Code Climate reported: + File `argon2.ts` has 281 lines of code (exceeds 250 allowed). Consider refactoring. * build(encrypted-archive): convert dynamic `import()` to CommonJS ESM does not work well in Jest * refactor(encrypted-archive): reduce lines in `src/key-derivation-function/argon2.ts` file Code Climate reported: + File `argon2.ts` has 253 lines of code (exceeds 250 allowed). Consider refactoring. * chore(encrypted-archive): move `argon2` to optionalDependencies * revert: test(encrypted-archive): fix test cases that use internal errors in the argon2 library This reverts commit b7ace6c. * revert: revert: test(encrypted-archive): fix test cases that use internal errors in the argon2 library This reverts commit 58b5f75.
I've updated emscripten emscripten-core/emscripten#16917. This issue will be fixed if you rebuild the argon2-browser with updated emscripten. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See simnalamburt/argon2-browser-error-repro for the error reproduction.
Works in Node.js < 18.1.0, fails with Node.js >= 18.1.0.
Works well if you disable experimental fetch:
This is due to change regarding
WebAssembly.instantiateStreaming
, which was added in Node.js v18.1.0.References
The text was updated successfully, but these errors were encountered: