Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve side panel button drawer #65

Merged
merged 9 commits into from
Oct 20, 2021
Merged

Conversation

laplamgor
Copy link
Collaborator

@laplamgor laplamgor commented Oct 19, 2021

Got tons of feedback in dcinside hoping for the return of "slide to toggle"


This update uses a modified Navigation Drawer to achieve a more easy-to-use "slide to toggle" interaction.

  • draw on top of the webview just like pre-2.8, no longer resize the game
  • add back "swipe to open panel" operation, with animation
    • also swipe in another direction to dismiss the panel like pre-2.8
  • smoother animation when toggling panel

Also minor UI changes:

  • toggle buttons on the side menu now use grey/yellow foreground color for disabled/enabled states.
    • just to match the toggle switches on the entrance page
  • add a semi-transparent panel background, so the panel is more visible if overlapped on game content
  • add select ripple effects of material design to buttons
  • use a Google Fonts icon for Kantai3D toggle button
video_2021-10-20_02-08-25.mp4

on a Narrow screen (16:9)
Screenshot_1634667034

- overlay with game content just like before v2.8
- use a semi-transparent background instead of solid black
- add select ripple effects of material design to buttons
- add back "swipe to open panel" operation
- swipe in another direction to dismiss the panel
- smoother animation when toggling panel
@laplamgor laplamgor requested a review from antest1 October 19, 2021 18:14
@laplamgor laplamgor marked this pull request as draft October 20, 2021 11:25
@laplamgor laplamgor marked this pull request as ready for review October 20, 2021 12:35
@laplamgor laplamgor force-pushed the feature/new_button_drawer branch from 764c37e to 2c3a379 Compare October 20, 2021 13:12
@laplamgor
Copy link
Collaborator Author

Two more changes:

  • fix a bug: clicking inside webview also close the panel.
  • add an invisible margin to avoid mistakenly toggling the side panel

Addressing first comment: "편성누를때 가끔 눌림"
https://gall.dcinside.com/board/view/?id=kancolle_new1&no=75023&s_type=search_subject_memo&s_keyword=%EA%B3%A0%ED%86%A0&page=1

image

@antest1 antest1 merged commit 2170b8f into master Oct 20, 2021
@laplamgor laplamgor deleted the feature/new_button_drawer branch December 12, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants