Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add True Critical Hits mod #74

Merged
merged 1 commit into from
May 15, 2022

Conversation

Oradimi
Copy link
Contributor

@Oradimi Oradimi commented Feb 22, 2022

This mod deletes the line of the game's client responsible for displaying every damage above 39 as critical hits, every damage below 15 as not critical hits, and 0 damage hits as misses. It makes it possible to see the real nature of your ships' hits directly within the game.

There is currently a crash issue, where these lines in Settings Activity are causing a crash when opening the settings. Investigation needed. But commenting them out works, and the mod is functional.

image

This mod deletes the line of the game's client responsible for displaying every damage above 39 as critical hits, every damage below 15 as not critical hits, and 0 damage hits as misses. It makes it possible to see the real nature of your ships' hits directly within the game.
@laplamgor
Copy link
Collaborator

        stringsToReplace.put(
                "null\\),.{0,99}<\\=0x0\\?.{0,99}\\=0x0\\:.{0,99}<\\=.{0,99}\\?.{0,99}\\=0x2\\:.{0,99}<0xf&&0x2\\=\\=.{0,99}&&\\(_0x.{0,99}\\=0x1\\)",
                "null)");

will this regex work after game client update?

@Oradimi
Copy link
Contributor Author

Oradimi commented Feb 22, 2022

It should, at least for maintenances that don't touch on the basic battle display code. I guess we'll know whenever the maintenance ends.

@Oradimi
Copy link
Contributor Author

Oradimi commented Feb 22, 2022

Can confirm it still works after the update!

@antest1
Copy link
Owner

antest1 commented Mar 19, 2022

can you share the logcat error for the crash? seems that crash does not appear in my side.

@Oradimi
Copy link
Contributor Author

Oradimi commented Mar 19, 2022

can you share the logcat error for the crash? seems that crash does not appear in my side.

It might have been a compilation bug or something, it seems like I can't reproduce it again either, so I guess it's fine and good to go then.

@antest1 antest1 merged commit ae89521 into antest1:master May 15, 2022
@Oradimi Oradimi deleted the feature/true_critical_hits branch May 22, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants