Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crashes #79

Merged
merged 2 commits into from
May 15, 2022
Merged

Fix crashes #79

merged 2 commits into from
May 15, 2022

Conversation

laplamgor
Copy link
Collaborator

@laplamgor laplamgor commented May 14, 2022 •
edited
Loading

  1. For some reason KC3 subtitle data is corrupted and a logger caused a null pointer exception crash.
  2. Corrupted data is most likely caused by a new user not yet selecting any subtitle language (but Goto trying to run the English (KC3) subtitle logic, especially if the user doesn't have good network connection to Github website
    • a DummySubtitleProvider is now introduced for default logic
  3. Some users don't understand what KCCP is but choose it as the bypass method, caused an immediate crash at game start.
    • a toast message will warn the user now. (Korea translation missing)

@antest1 antest1 merged commit 1c23a72 into antest1:master May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laplamgor @antest1