feat: move to ESM first #91
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we should also update node to 16 or maybe to 18... |
|
I am not sure. In many usage the vite.config.ts might be a CJS. Requiring for dynamic import is not really worth it to me. And I don't actually mind to have "Masqureading CJS types" |
|
@antfu We need to copy |
|
@sxzz maybe we can have CJS and ESM configured properly, something like this: |
|
On the opposite, unjs/unbuild#273, I thought that TS will look for the corresponding types based on the file name in node16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we have:
Moving to ESM first: