fix: properly disable top-level-await rule for tests

antfu · Sep 26, 2024 · e914ae4 · e914ae4
1 parent 582ade4
commit e914ae4
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 11 deletions.
diff --git a/src/configs/disables.ts b/src/configs/disables.ts
@@ -39,14 +39,6 @@ export async function disables(): Promise<TypedFlatConfigItem[]> {
         'unused-imports/no-unused-vars': 'off',
       },
     },
-    {
-      files: ['**/*.{test,spec}.([tj])s?(x)'],
-      name: 'antfu/disables/test',
-      rules: {
-        'antfu/no-top-level-await': 'off',
-        'no-unused-expressions': 'off',
-      },
-    },
     {
       files: ['**/*.js', '**/*.cjs'],
       name: 'antfu/disables/cjs',

diff --git a/src/configs/test.ts b/src/configs/test.ts
@@ -44,16 +44,21 @@ export async function test(
       files,
       name: 'antfu/test/rules',
       rules: {
-        'node/prefer-global/process': 'off',
-
         'test/consistent-test-it': ['error', { fn: 'it', withinDescribe: 'it' }],
         'test/no-identical-title': 'error',
         'test/no-import-node-test': 'error',
         'test/no-only-tests': isInEditor ? 'off' : 'error',
+
         'test/prefer-hooks-in-order': 'error',
         'test/prefer-lowercase-title': 'error',
 
-        'ts/explicit-function-return-type': 'off',
+        // Disables
+        ...{
+          'antfu/no-top-level-await': 'off',
+          'no-unused-expressions': 'off',
+          'node/prefer-global/process': 'off',
+          'ts/explicit-function-return-type': 'off',
+        },
 
         ...overrides,
       },