Skip to content
This repository has been archived by the owner on Feb 7, 2024. It is now read-only.

docs: add note about compatibility with markdown-it-attrs #93

Merged
merged 3 commits into from
Jan 14, 2024
Merged

docs: add note about compatibility with markdown-it-attrs #93

merged 3 commits into from
Jan 14, 2024

Conversation

uncenter
Copy link
Contributor

Description

Adds note about possible compatibility issues with another markdown-it plugin.

Linked Issues

Closes #88.

Copy link

netlify bot commented Jan 13, 2024

Deploy Preview for shikiji ready!

Name Link
🔨 Latest commit f676c46
🔍 Latest deploy log https://app.netlify.com/sites/shikiji/deploys/65a31326ee76ec0008c51fdf
😎 Deploy Preview https://deploy-preview-93--shikiji.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5f1efbc) 92.42% compared to head (f676c46) 92.42%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #93   +/-   ##
=======================================
  Coverage   92.42%   92.42%           
=======================================
  Files          52       52           
  Lines        4556     4556           
  Branches      535      535           
=======================================
  Hits         4211     4211           
  Misses        340      340           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uncenter
Copy link
Contributor Author

Should the notice stay where I put it or maybe under the line highlight feature section since it only really applies there?

@antfu
Copy link
Owner

antfu commented Jan 13, 2024

Yeah I think putting it under highlight with a ::: note callout would be better indeed

@uncenter
Copy link
Contributor Author

uncenter commented Jan 13, 2024

I'm getting this error when I try to run pnpm docs:dev.

> @ docs:dev /Users/uncenter/Dev/shikiji/docs
> vitepress dev

node:internal/modules/esm/resolve:264
    throw new ERR_MODULE_NOT_FOUND(
          ^

Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/Users/uncenter/Dev/shikiji/node_modules/.pnpm/vitepress@1.0.0-rc.36_@algolia+client-search@4.22.0_@types+node@20.11.0_fuse.js@7.0.0_postcss_qmjcx63xrjf7mow5n2ei3uex4m/node_modules/shikiji/dist/index.mjs' imported from /Users/uncenter/Dev/shikiji/node_modules/.pnpm/vitepress@1.0.0-rc.36_@algolia+client-search@4.22.0_@types+node@20.11.0_fuse.js@7.0.0_postcss_qmjcx63xrjf7mow5n2ei3uex4m/node_modules/vitepress/dist/node/cli.js
    at finalizeResolution (node:internal/modules/esm/resolve:264:11)
    at moduleResolve (node:internal/modules/esm/resolve:917:10)
    at defaultResolve (node:internal/modules/esm/resolve:1130:11)
    at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:396:12)
    at ModuleLoader.resolve (node:internal/modules/esm/loader:365:25)
    at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:240:38)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:85:39)
    at link (node:internal/modules/esm/module_job:84:36) {
  code: 'ERR_MODULE_NOT_FOUND',
  url: 'file:///Users/uncenter/Dev/shikiji/node_modules/.pnpm/vitepress@1.0.0-rc.36_@algolia+client-search@4.22.0_@types+node@20.11.0_fuse.js@7.0.0_postcss_qmjcx63xrjf7mow5n2ei3uex4m/node_modules/shikiji/dist/index.mjs'
}

Node.js v20.11.0
 ELIFECYCLE  Command failed with exit code 1.
 

@antfu antfu merged commit da394fb into antfu:main Jan 14, 2024
13 checks passed
@uncenter uncenter deleted the docs/add-compat-note branch January 14, 2024 03:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[markdown-it-shikiji]: Issues with line number highlights while using markdown-it-attrs
2 participants