Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: can not close dts #16

Merged
merged 2 commits into from
Jan 11, 2024
Merged

fix: can not close dts #16

merged 2 commits into from
Jan 11, 2024

Conversation

ShenQingchuan
Copy link
Contributor

@ShenQingchuan ShenQingchuan commented Jan 10, 2024

Description

Supplement fix for #15, because I found that the configuration closeDts didn't take any effect.

I refactored the if statement condition expression to represent its relation with those .d.ts files, more directly & clearly.

Additional context

I add a devDependency cross-env for giving environment variables for dev/build scripts to generate sourcemap, in order to make debugger setting breakpoint easier.

@antfu
Copy link
Owner

antfu commented Jan 11, 2024

You don't really need cross-env: https://petermekhaeil.com/til/pnpm-shell-emulator/

@antfu antfu merged commit 29412a3 into antfu:main Jan 11, 2024
2 checks passed
@ShenQingchuan
Copy link
Contributor Author

You don't really need cross-env: https://petermekhaeil.com/til/pnpm-shell-emulator/

Thanks♪(・ω・)ノ
TIL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants