move common params check to class IndexCommonParam #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
LHT129
commented
Nov 1, 2024
LHT129
commented
- common params(dim,metric_type,data_type...) should be checked for all index
- add param value's datatype check for hnsw and common params
LHT129
added
the
kind/improvement
LHT129
force-pushed
the
param_check
branch
2 times, most recently
from
0e12c80 to
9536ab5
Compare
- common params(dim,metric_type,data_type...) should be checked for all index - add param value's datatype check for hnsw and common params Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
inabao
reviewed
Nov 1, 2024
| CHECK_ARGUMENT(metric_obj.is_string(), | ||
| fmt::format("parameters[{}] must string type", PARAMETER_METRIC_TYPE)); | ||
| std::string metric = metric_obj; | ||
| if (metric == METRIC_L2) { |
There was a problem hiding this comment.
Perhaps we don't need to require strict string equality here; we can ignore case.
There was a problem hiding this comment.
we can discuss the strict equality on another pull request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.