refactor the code for index parameter parsing #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 12, 2024 00:00
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
inabao
added
the
kind/improvement
added 3 commits
November 12, 2024 00:35
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
jiaweizone
reviewed
Nov 13, 2024
| } else { | ||
| common_param.allocator_ = DefaultAllocator::Instance().get(); | ||
| if (allocator == nullptr) { | ||
| index_common_params.allocator_ = DefaultAllocator::Instance().get(); |
There was a problem hiding this comment.
the allocator_ can change to shared_ptr ?
There was a problem hiding this comment.
The allocator_ may be passed in as a raw pointer from outside.
added 4 commits
November 14, 2024 15:11
LHT129
requested changes
Nov 19, 2024
added 3 commits
November 21, 2024 22:43
jiaweizone
reviewed
Nov 24, 2024
| @@ -24,10 +24,10 @@ | |||
| namespace vsag { | |||
| class HGraphParameters { | |||
| public: | |||
| explicit HGraphParameters(const IndexCommonParam& common_param, const std::string& str = ""); | |||
| explicit HGraphParameters(JsonType& hgraph_param, const IndexCommonParam& common_param); | |||
There was a problem hiding this comment.
Keep a consistent params sequence style:
explicit HGraphParams(const IndexCommonParam& common_param, JsonType& hgraph_param)
There was a problem hiding this comment.
I have refactored all the construct function of index to the style like HGraphParameters(JsonType& hgraph_param, const IndexCommonParam& common_param); to keep the same style with data_cell
jiaweizone
approved these changes
Nov 27, 2024
| @@ -31,6 +32,6 @@ class IndexCommonParam { | |||
| Allocator* allocator_{nullptr}; | |||
There was a problem hiding this comment.
public fields do not need to end with _
change in next PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.