Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compile error in clang17 #127

Merged
merged 1 commit into from
Nov 12, 2024
Merged

fix compile error in clang17 #127

merged 1 commit into from
Nov 12, 2024

Conversation

inabao
Copy link
Collaborator

@inabao inabao commented Nov 12, 2024

fixed: #116

Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
Copy link
Collaborator

@LHT129 LHT129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wxyucs wxyucs added the kind/bug Something isn't working label Nov 12, 2024
Copy link
Collaborator

@wxyucs wxyucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -42,7 +42,7 @@ TEST_CASE("graph basic test", "[ut][graph_datacell]") {
auto max_degrees = {5, 12, 24, 32, 64, 128};
auto max_capacities = {1, 100, 10000, 10'000'000, 32'179'837};
std::vector<JsonType> graph_params;
std::string graph_param_temp = R"(
constexpr const char* graph_param_temp = R"(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the warning here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have pasted the screenshot in issue #128

Copy link
Collaborator

@ZhitaoShen ZhitaoShen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@jiaweizone jiaweizone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@inabao inabao merged commit 2c72eee into main Nov 12, 2024
2 checks passed
@inabao inabao deleted the fix-compile-error-in-clang17 branch November 12, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error in the compilation of clang17
5 participants