Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alias nlohmann::json to JsonType #133

Merged
merged 1 commit into from
Nov 15, 2024
Merged

alias nlohmann::json to JsonType #133

merged 1 commit into from
Nov 15, 2024

Conversation

LHT129
Copy link
Collaborator

@LHT129 LHT129 commented Nov 13, 2024

No description provided.

@LHT129 LHT129 added the kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) label Nov 13, 2024
@LHT129 LHT129 requested a review from wxyucs November 13, 2024 10:06
@LHT129 LHT129 self-assigned this Nov 13, 2024
@LHT129 LHT129 requested a review from jiaweizone as a code owner November 13, 2024 10:06
@LHT129 LHT129 force-pushed the json_type branch 3 times, most recently from bc2578b to 12c0865 Compare November 13, 2024 11:16
Copy link
Collaborator

@inabao inabao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
Copy link
Collaborator

@jiaweizone jiaweizone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LHT129 LHT129 merged commit 677558a into antgroup:main Nov 15, 2024
2 checks passed
@LHT129 LHT129 deleted the json_type branch November 15, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants