Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move the Vector, UnorderMap, ... to typing.h #144

Merged
merged 1 commit into from
Nov 21, 2024
Merged

move the Vector, UnorderMap, ... to typing.h #144

merged 1 commit into from
Nov 21, 2024

Conversation

LHT129
Copy link
Collaborator

@LHT129 LHT129 commented Nov 17, 2024

No description provided.

@LHT129 LHT129 added the kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) label Nov 17, 2024
@LHT129 LHT129 requested a review from inabao November 17, 2024 05:13
@LHT129 LHT129 self-assigned this Nov 17, 2024
@LHT129 LHT129 requested a review from jiaweizone as a code owner November 17, 2024 05:13
@LHT129
move the Vector, Unordermap, ... to typing.h
a28a1db 
Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
inabao
inabao approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@inabao inabao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wxyucs
wxyucs approved these changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@wxyucs wxyucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jiaweizone
jiaweizone approved these changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@jiaweizone jiaweizone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LHT129 LHT129 merged commit 5a2de4b into antgroup:main Nov 21, 2024
2 checks passed
@LHT129 LHT129 deleted the typing branch November 21, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inabao inabao inabao approved these changes

@wxyucs wxyucs wxyucs approved these changes

@jiaweizone jiaweizone jiaweizone approved these changes

Assignees

@LHT129 LHT129

Labels
kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LHT129 @jiaweizone @wxyucs @inabao