Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split allocator_wrapper and default Allocator #145

Merged
merged 1 commit into from
Nov 20, 2024
Merged

split allocator_wrapper and default Allocator #145

merged 1 commit into from
Nov 20, 2024

Conversation

LHT129
Copy link
Collaborator

@LHT129 LHT129 commented Nov 17, 2024

No description provided.

@LHT129 LHT129 added the kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) label Nov 17, 2024
@LHT129 LHT129 self-assigned this Nov 17, 2024
@LHT129 LHT129 requested a review from jiaweizone as a code owner November 17, 2024 05:54
@LHT129
split allocator_wrapper and default Allocator
bfe0c3a 
Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
inabao
inabao approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@inabao inabao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jiaweizone
jiaweizone approved these changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@jiaweizone jiaweizone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LHT129 LHT129 merged commit f7846e3 into antgroup:main Nov 20, 2024
2 checks passed
@LHT129 LHT129 deleted the split_class branch November 20, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inabao inabao inabao approved these changes

@jiaweizone jiaweizone jiaweizone approved these changes

@wxyucs wxyucs Awaiting requested review from wxyucs wxyucs is a code owner

@ShawnShawnYou ShawnShawnYou Awaiting requested review from ShawnShawnYou ShawnShawnYou is a code owner

Assignees

@LHT129 LHT129

Labels
kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LHT129 @jiaweizone @inabao