Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use TEST_CASE_PERSISTENT_FIXTURE instead TEST_CASE_METHOD #149

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

LHT129
Copy link
Collaborator

@LHT129 LHT129 commented Nov 19, 2024

  • static var in test_index is not a good idea
  • make one instance per test_case

- static var in test_index is not a good idea
- make one instance per test_case

Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
@LHT129 LHT129 added the kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) label Nov 19, 2024
@LHT129 LHT129 self-assigned this Nov 19, 2024
@LHT129 LHT129 requested a review from inabao November 19, 2024 09:04
Copy link
Collaborator

@jiaweizone jiaweizone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@wxyucs wxyucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LHT129 LHT129 merged commit e1dd45d into antgroup:main Nov 20, 2024
2 checks passed
@LHT129 LHT129 deleted the test_index branch November 20, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants