Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add general test for hgraph #181

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

LHT129
Copy link
Collaborator

@LHT129 LHT129 commented Dec 3, 2024

#40

  • only factory & build/add & general test
  • no test for range search

@LHT129 LHT129 added the kind/feature New feature or request label Dec 3, 2024
@LHT129 LHT129 self-assigned this Dec 3, 2024
@LHT129 LHT129 force-pushed the hgraph_test_general branch 2 times, most recently from e3afa9e to 68f2c8d Compare December 3, 2024 14:54
@LHT129 LHT129 force-pushed the hgraph_test_general branch from 68f2c8d to f41d120 Compare December 4, 2024 06:26
@@ -96,7 +96,7 @@ const std::string HGraphParameters::DEFAULT_HGRAPH_PARAMS = format_map(
"type": "nsw",
"{GRAPH_PARAMS_KEY}": {
"{GRAPH_PARAM_MAX_DEGREE}": 64,
"{GRAPH_PARAM_INIT_MAX_CAPACITY}": 1000
"{GRAPH_PARAM_INIT_MAX_CAPACITY}": 100
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change default value ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

our test is 1000, to test the resize is right, we should set default count less than 1000

tests/fixtures/fixtures.cpp Outdated Show resolved Hide resolved
tests/test_index.cpp Show resolved Hide resolved
@LHT129 LHT129 force-pushed the hgraph_test_general branch from f41d120 to 065280d Compare December 4, 2024 11:41
Copy link
Collaborator

@jiaweizone jiaweizone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LHT129 LHT129 force-pushed the hgraph_test_general branch from 065280d to afc8103 Compare December 4, 2024 14:17
- only factory & build/add & general test
- no test for range search

Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
@LHT129 LHT129 force-pushed the hgraph_test_general branch from afc8103 to 1b4c5d2 Compare December 4, 2024 14:19
@LHT129 LHT129 merged commit 95ddb05 into antgroup:main Dec 4, 2024
2 checks passed
@LHT129 LHT129 deleted the hgraph_test_general branch December 4, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants