handle the bad alloc exception in vector search #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxyucs
force-pushed
the
handlering_bad_alloc_exception
branch
from
82be33e to
84987d6
Compare
jiaweizone
reviewed
Sep 6, 2024
| @@ -70,7 +72,7 @@ HNSW::HNSW(std::shared_ptr<hnswlib::SpaceInterface> space_interface, | |||
| if (not allocator) { | |||
| allocator = DefaultAllocator::Instance(); | |||
| } | |||
| allocator_ = allocator; | |||
| allocator_ = new SafeAllocator(allocator); | |||
There was a problem hiding this comment.
SafeAllocator need free ?
There was a problem hiding this comment.
fixed, release at deconstruct function
Signed-off-by: Xiangyu Wang <wxy407827@antgroup.com>
wxyucs
force-pushed
the
handlering_bad_alloc_exception
branch
from
84987d6 to
598dd60
Compare
wxyucs
changed the title
wxyucs
added a commit
that referenced
this pull request
Sep 11, 2024
Signed-off-by: Xiangyu Wang <wxy407827@antgroup.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.