refactor hgraph_params to solve static value leak #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LHT129
added
the
kind/improvement
LHT129
requested review from
inabao,
wxyucs and
ShawnShawnYou
as code owners
LHT129
force-pushed
the
fix_leak
branch
2 times, most recently
from
1788206 to
8bab914
Compare
jiaweizone
reviewed
Dec 18, 2024
src/index/hgraph_zparameters.cpp
Outdated
| {HGRAPH_GRAPH_MAX_DEGREE, {HGRAPH_GRAPH_KEY, GRAPH_PARAMS_KEY, GRAPH_PARAM_MAX_DEGREE}}, | ||
| {HGRAPH_BUILD_EF_CONSTRUCTION, {BUILD_PARAMS_KEY, BUILD_EF_CONSTRUCTION}}}; | ||
|
|
||
| static const std::string DEFAULT_HGRAPH_PARAMS_STR = |
There was a problem hiding this comment.
DEFAULT_HGRAPH_PARAMS_STR -> HGRAPH_PARAMS_TEMPLATE ?
src/index/hgraph_zparameters.cpp
Outdated
| : common_param_(common_param) { | ||
| : common_param_(common_param), | ||
| default_hgraph_params_(format_map(DEFAULT_HGRAPH_PARAMS_STR, DEFAULT_MAP)), | ||
| hgraph_param_mapping_(EXTERNAL_MAPPING) { |
There was a problem hiding this comment.
Why need an EXTERNAL_MAPPING object copy ?
There was a problem hiding this comment.
remove the value now.
LHT129
force-pushed
the
fix_leak
branch
3 times, most recently
from
1619268 to
6735e20
Compare
Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed: #222