Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix pyvsag undefined symbol error #24

Merged
merged 1 commit into from
Sep 11, 2024
Merged

fix pyvsag undefined symbol error #24

merged 1 commit into from
Sep 11, 2024

Conversation

wxyucs
Copy link
Collaborator

@wxyucs wxyucs commented Sep 11, 2024

fix undefined symbol error in import pyvsag:

>>> import pyvsag
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ImportError: /home/ubuntu/vsag/build/pyvsag.cpython-312-aarch64-linux-gnu.so: undefined symbol: _ZN4vsag17kmeans_clusteringEmmmPKfPfRKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE

@wxyucs
fix pyvsag undefined symbol error
55ddb55 
Signed-off-by: wxy407827 <wxy407827@antgroup.com>
@wxyucs wxyucs added the kind/bug Something isn't working label Sep 11, 2024
@wxyucs wxyucs requested review from jiaweizone and LHT129 September 11, 2024 08:39
@wxyucs wxyucs self-assigned this Sep 11, 2024
@wxyucs wxyucs requested a review from inabao September 11, 2024 08:41
LHT129
LHT129 approved these changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@LHT129 LHT129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jiaweizone
jiaweizone approved these changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@jiaweizone jiaweizone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

python_bindings/binding.cpp
auto data_size = data_shape[0];
auto dimension = data_shape[1];
auto centroids = py::array_t<float>(py::array::ShapeContainer{py_clusters, dimension});
vsag::kmeans_clustering(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK，remove unsupported method

@wxyucs wxyucs merged commit 51ae63a into main Sep 11, 2024
3 checks passed
@wxyucs wxyucs deleted the fix_pyvsag_undefined_symbol branch September 11, 2024 09:18
wxyucs added a commit that referenced this pull request Sep 11, 2024
@wxyucs
fix pyvsag undefined symbol error (#24)
dfd6033 
Signed-off-by: wxy407827 <wxy407827@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LHT129 LHT129 LHT129 approved these changes

@inabao inabao inabao approved these changes

@jiaweizone jiaweizone jiaweizone approved these changes

Assignees

@wxyucs wxyucs

Labels
kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wxyucs @jiaweizone @inabao @LHT129