Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix arm compile error #240

Merged
merged 1 commit into from
Dec 24, 2024
Merged

fix arm compile error #240

merged 1 commit into from
Dec 24, 2024

Conversation

LHT129
Copy link
Collaborator

@LHT129 LHT129 commented Dec 20, 2024

fixed: #238

  • add arm test on ci

@LHT129 LHT129 added the kind/bug Something isn't working label Dec 20, 2024
@LHT129 LHT129 requested a review from wxyucs December 20, 2024 08:57
@LHT129 LHT129 self-assigned this Dec 20, 2024
@pull-request-size pull-request-size bot added size/M and removed size/S labels Dec 21, 2024
@LHT129 LHT129 force-pushed the arm branch 2 times, most recently from 337c145 to bf0c59d Compare December 21, 2024 04:52
@@ -12,8 +12,9 @@
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

#if defined(ENABLE_AVX512)
#include <immintrin.h>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, fix ARM compile issue

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah

filters:
branches:
ignore:
- main
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why main branch need skip ARM platform check ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pull request ignore main, if merged another workflow run

@LHT129 LHT129 force-pushed the arm branch 13 times, most recently from cc5cafb to 27bb35c Compare December 23, 2024 07:47
@pull-request-size pull-request-size bot added size/L and removed size/M labels Dec 23, 2024
@LHT129 LHT129 force-pushed the arm branch 2 times, most recently from 13ec324 to 832da8d Compare December 23, 2024 08:17
@LHT129 LHT129 force-pushed the arm branch 2 times, most recently from a23adf1 to 792b5e1 Compare December 23, 2024 11:14
@LHT129 LHT129 changed the title [WIP]fix arm compile error fix arm compile error Dec 24, 2024
@LHT129 LHT129 marked this pull request as ready for review December 24, 2024 03:10
resource_class: arm.medium
steps:
- checkout
- run: apt update && apt install -y gfortran python3-dev libomp-15-dev gcc make cmake g++
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace with the dependencies install script in scripts/deps/

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

- add arm test on ci

Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
Copy link
Collaborator

@wxyucs wxyucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@jiaweizone jiaweizone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LHT129 LHT129 merged commit 2698dcb into antgroup:main Dec 24, 2024
8 checks passed
@LHT129 LHT129 deleted the arm branch December 24, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working size/L version/0.12
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compile failed on ARM: fatal error: x86intrin.h: No such file or directory
4 participants