define the interface for merging indexes #312
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inabao
requested review from
wxyucs,
LHT129,
ShawnShawnYou and
jiaweizone
as code owners
Codecov ReportAttention: Patch coverage is @@ Coverage Diff @@
## main #312 +/- ##
==========================================
+ Coverage 90.81% 90.85% +0.04%
==========================================
Files 133 134 +1
Lines 8402 8487 +85
==========================================
+ Hits 7630 7711 +81
- Misses 772 776 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
inabao
force-pushed
the
merge-index
branch
2 times, most recently
from
f85f686 to
1daa52f
Compare
added 3 commits
January 21, 2025 17:55
LHT129
reviewed
Jan 22, 2025
| */ | ||
| virtual tl::expected<void, Error> | ||
| Merge(const std::vector<std::shared_ptr<Index>>& sub_indexes) { | ||
| throw std::runtime_error("Index doesn't support check feature"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#318