Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add example for brute force and hgraph #331

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Conversation

LHT129
Copy link
Collaborator

@LHT129 LHT129 commented Jan 15, 2025

@LHT129 LHT129 added the kind/feature New feature or request label Jan 15, 2025
@LHT129 LHT129 self-assigned this Jan 15, 2025
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

@@            Coverage Diff             @@
##             main     #331      +/-   ##
==========================================
- Coverage   86.29%   86.22%   -0.08%     
==========================================
  Files         114      114              
  Lines        7115     7115              
==========================================
- Hits         6140     6135       -5     
- Misses        975      980       +5     
Flag Coverage Δ
cpp 86.22% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 89.80% <ø> (ø)
datacell 90.03% <ø> (-0.24%) ⬇️
index 84.20% <ø> (-0.05%) ⬇️
simd 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfd685a...29e052c. Read the comment docs.

examples/cpp/todo_examples/103_index_hgraph.cpp Outdated Show resolved Hide resolved
examples/cpp/todo_examples/105_index_brute_force.cpp Outdated Show resolved Hide resolved
examples/cpp/todo_examples/CMakeLists.txt Outdated Show resolved Hide resolved
@LHT129 LHT129 force-pushed the example branch 2 times, most recently from a044adf to 97436d5 Compare January 16, 2025 03:28
Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
Copy link
Collaborator

@wxyucs wxyucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

"ef_construction": 100
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can point out the available options for these parameters here, as well as whether they are required or optional.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not here but in docs

Copy link
Collaborator

@inabao inabao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LHT129 LHT129 merged commit a50b341 into antgroup:main Jan 16, 2025
12 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants