Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use trunc train for sq as default #356

Merged
merged 1 commit into from
Feb 13, 2025
Merged

use trunc train for sq as default #356

merged 1 commit into from
Feb 13, 2025

Conversation

LHT129
Copy link
Collaborator

@LHT129 LHT129 commented Jan 21, 2025

No description provided.

@LHT129 LHT129 added kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) version/0.14 labels Jan 21, 2025
@LHT129 LHT129 self-assigned this Jan 21, 2025
@LHT129 LHT129 requested a review from ShawnShawnYou as a code owner January 21, 2025 12:10
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

@@            Coverage Diff             @@
##             main     #356      +/-   ##
==========================================
- Coverage   91.28%   91.25%   -0.03%     
==========================================
  Files         140      140              
  Lines        8968     8968              
==========================================
- Hits         8186     8184       -2     
- Misses        782      784       +2     
Flag Coverage Δ
cpp 91.25% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 95.54% <ø> (ø)
datacell 92.50% <ø> (+0.07%) ⬆️
index 91.44% <ø> (-0.07%) ⬇️
simd 81.72% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acc0815...f635fb5. Read the comment docs.

@LHT129 LHT129 force-pushed the sq branch 3 times, most recently from ad8c823 to 66a2cea Compare January 22, 2025 11:18
@LHT129 LHT129 force-pushed the sq branch 2 times, most recently from 9b0c93c to f77d13b Compare February 10, 2025 03:44
Copy link
Collaborator

@inabao inabao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@wxyucs wxyucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LHT129 LHT129 force-pushed the sq branch 2 times, most recently from fe4145c to 6511416 Compare February 12, 2025 06:21
Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
@LHT129 LHT129 merged commit 0f3a98f into antgroup:main Feb 13, 2025
16 checks passed
@LHT129 LHT129 deleted the sq branch February 13, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) size/S version/0.14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants