Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the implementation of the pyramid from being index-based to datacell-based #370

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

inabao
Copy link
Collaborator

@inabao inabao commented Feb 1, 2025

No description provided.

@inabao inabao added the kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) label Feb 1, 2025
@inabao inabao self-assigned this Feb 1, 2025
Copy link

codecov bot commented Feb 1, 2025

Codecov Report

Attention: Patch coverage is 78.44311% with 72 lines in your changes missing coverage. Please review.

❌ Your patch check has failed because the patch coverage (78.44%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

@@            Coverage Diff             @@
##             main     #370      +/-   ##
==========================================
- Coverage   91.17%   91.01%   -0.16%     
==========================================
  Files         134      133       -1     
  Lines        8732     8812      +80     
==========================================
+ Hits         7961     8020      +59     
- Misses        771      792      +21     
Flag Coverage Δ
cpp 91.01% <78.44%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 95.90% <100.00%> (+0.15%) ⬆️
datacell 93.29% <ø> (+1.18%) ⬆️
index 90.55% <76.77%> (-0.71%) ⬇️
simd 81.72% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11f89df...bd6ae0f. Read the comment docs.

…tacell-based

Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
jinjiabao.jjb added 3 commits February 5, 2025 10:54
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant