remove redundant judgments during the HNSW search process #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 24, 2024 14:54
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
wxyucs
added
the
kind/improvement
jiaweizone
reviewed
Sep 24, 2024
| @@ -1404,13 +1404,9 @@ HierarchicalNSW::searchKnn(const void* query_data, | |||
| } | |||
|
|
|||
| MaxHeap top_candidates; | |||
| if (num_deleted_) { | |||
| top_candidates = | |||
| searchBaseLayerST<true, true>(currObj, query_data, std::max(ef, k), isIdAllowed); | |||
There was a problem hiding this comment.
Why remove this logic ?
There was a problem hiding this comment.
num_deleted_ is the original logic for marking deletions in HNSW, but we no longer rely on this logic.
inabao
added a commit
that referenced
this pull request
Oct 24, 2024
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.