Add Graph Interface #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
LHT129
force-pushed
the
graph_interface
branch
from
9cc3f72 to
d81a715
Compare
ShawnShawnYou
approved these changes
Oct 11, 2024
inabao
approved these changes
Oct 11, 2024
jiaweizone
reviewed
Oct 11, 2024
| virtual void | ||
| IncreaseTotalCount(uint64_t count) { | ||
| std::unique_lock<std::mutex> lock(global_); | ||
| total_count_ += count; |
There was a problem hiding this comment.
Can we use atomic increment here?
There was a problem hiding this comment.
now use lock in external Index, we will apply atomic in the datacell layer or add concurrent interface in future
|
|
||
| virtual void | ||
| SetMaxCapacity(uint64_t capacity) { | ||
| this->max_capacity_ = std::max(capacity, this->total_count_); |
There was a problem hiding this comment.
max_capacity_ equals total_count_ ?
There was a problem hiding this comment.
max_capacity_ >= total_count_, equal is allowed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #40