support int8 for hnsw #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
added 4 commits
October 15, 2024 15:03
LHT129
reviewed
Oct 16, 2024
jiaweizone
reviewed
Oct 22, 2024
src/index/hnsw.cpp
Outdated
| vectors = (void*)base->GetInt8Vectors(); | ||
| data_size = dim_ * sizeof(int8_t); | ||
| } else { | ||
| throw std::invalid_argument("fail to support this data type"); |
There was a problem hiding this comment.
the exception message need include unknown type id
There was a problem hiding this comment.
i removed this choice because the part will be completed during the parameter checking phase
There was a problem hiding this comment.
For this function, it is still recommended to add a check for the parameter type_.
added 4 commits
October 23, 2024 11:54
jiaweizone
approved these changes
Oct 23, 2024
| } else if (type == vsag::DataTypes::DATA_TYPE_INT8) { | ||
| fstdistfunc_ = vsag::GetINT8InnerProductDistanceFunc(dim); | ||
| data_size_ = dim * sizeof(int8_t); | ||
| } |
There was a problem hiding this comment.
Here need process unsupported type
src/data_type.h
Outdated
| case DataTypes::DATA_TYPE_FP16: | ||
| return "float16"; | ||
| } | ||
| return "unknown type"; |
There was a problem hiding this comment.
return "unknown type (" + std::to_string(type(int)) + ")";
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #64