using typing.h to define LabelType and InnerIdType #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LHT129
added
the
kind/improvement
Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
inabao
approved these changes
Oct 17, 2024
wxyucs
reviewed
Oct 17, 2024
Comment on lines
+22
to
+23
| using InnerIdType = uint32_t; // inner id's type; index's vector count may less than 2^31 - 1 | ||
| using LabelType = uint64_t; // external id's type |
There was a problem hiding this comment.
@LHT129 ID type should change to signed integer to avoid type-casting while calling from library interfaces
wxyucs
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.