Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update simd operators for special dims #77

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

LHT129
Copy link
Collaborator

@LHT129 LHT129 commented Oct 22, 2024

update sq8 simd operators for special dims (not power of 2)

@LHT129 LHT129 self-assigned this Oct 22, 2024
@LHT129 LHT129 requested a review from ShawnShawnYou as a code owner October 22, 2024 04:07
@LHT129 LHT129 added the kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) label Oct 22, 2024
Copy link
Collaborator

@wxyucs wxyucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -54,11 +54,11 @@ TEST_CASE("SQ8 SIMD Compute Codes", "[SQ8 SIMD]") {
std::vector<uint8_t> vec1, vec2;
for (const auto& dim : dims) {
auto vec = fixtures::generate_vectors(count * 2, dim);
vec1.resize(count * dim * 2, 0);
vec1.resize(count * dim);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modify all self-defined dims to common_used_dims

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@LHT129 LHT129 force-pushed the update_simd branch 5 times, most recently from 45cd9f1 to c37e634 Compare October 22, 2024 05:44
Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
Copy link
Collaborator

@jiaweizone jiaweizone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LHT129 LHT129 merged commit 111556f into antgroup:main Oct 23, 2024
2 checks passed
@LHT129 LHT129 deleted the update_simd branch January 17, 2025 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) module/simd size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants