Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make simd operators global (not only in simd/) #78

Merged
merged 1 commit into from
Oct 23, 2024
Merged

make simd operators global (not only in simd/) #78

merged 1 commit into from
Oct 23, 2024

Conversation

LHT129
Copy link
Collaborator

@LHT129 LHT129 commented Oct 22, 2024

  • change simd CmakeLists to enable simd operators global
  • fix some typo errors

@LHT129
make simd operators globel (not only in simd/)
fc468a4 
- change simd CmakeLists to enable simd operators global
- fix some typo errors

Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
@LHT129 LHT129 requested a review from wxyucs October 22, 2024 08:15
@LHT129 LHT129 self-assigned this Oct 22, 2024
@LHT129 LHT129 requested a review from ShawnShawnYou as a code owner October 22, 2024 08:15
@LHT129 LHT129 added kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) size/M and removed size/M labels Oct 22, 2024
@LHT129 LHT129 changed the title make simd operators globel (not only in simd/) make simd operators global (not only in simd/) Oct 22, 2024
inabao
inabao approved these changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@inabao inabao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wxyucs
wxyucs approved these changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@wxyucs wxyucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LHT129 LHT129 merged commit f134810 into antgroup:main Oct 23, 2024
2 checks passed
@LHT129 LHT129 deleted the typo branch January 17, 2025 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShawnShawnYou ShawnShawnYou ShawnShawnYou approved these changes

@inabao inabao inabao approved these changes

@wxyucs wxyucs wxyucs approved these changes

Assignees

@LHT129 LHT129

Labels
kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) module/simd size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LHT129 @wxyucs @inabao @ShawnShawnYou