enable allocator for quantizers #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inabao
reviewed
Oct 23, 2024
| computer.buf_ = reinterpret_cast<uint8_t*>(this->allocator_->Allocate(this->code_size_)); | ||
| } catch (const std::bad_alloc& e) { | ||
| computer.buf_ = nullptr; | ||
| logger::error("bad alloc when init computer buf"); |
There was a problem hiding this comment.
does it matter for memcpy(computer.buf_, query, this->code_size_) when computer.buf_ is nullpter
| computer.buf_ = reinterpret_cast<uint8_t*>(this->allocator_->Allocate(aligned_size)); | ||
| } catch (const std::bad_alloc& e) { | ||
| computer.buf_ = nullptr; | ||
| logger::error("bad alloc when init computer buf"); |
LHT129
force-pushed
the
quantizer_allocator
branch
2 times, most recently
from
0f610f9 to
91bb191
Compare
inabao
approved these changes
Oct 23, 2024
LHT129
force-pushed
the
quantizer_allocator
branch
3 times, most recently
from
d97b00e to
068f12a
Compare
jiaweizone
reviewed
Oct 25, 2024
| @@ -35,7 +35,7 @@ template <typename T> | |||
| class Computer : public ComputerInterface { | |||
| public: | |||
| ~Computer() { | |||
| delete[] buf_; | |||
| quantizer_->ReleaseComputer(*this); | |||
There was a problem hiding this comment.
Why use quantizer to release anther class instance ?
There was a problem hiding this comment.
the buf is allocated by the quantizer
src/quantization/sq8_quantizer.h
Outdated
| @@ -96,7 +101,8 @@ SQ8Quantizer<metric>::TrainImpl(const vsag::DataType* data, uint64_t count) { | |||
| if (this->is_trained_) { | |||
| return true; | |||
| } | |||
| std::vector<DataType> upperBound(this->dim_, std::numeric_limits<DataType>::lowest()); | |||
| Vector<DataType> upperBound( | |||
- use allocator to manager Computer - use allocator for quantizer - update ip to 1-ip for InnerProduct metric - ignore flatten_datacell_test which will be enable by following pr Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
LHT129
force-pushed
the
quantizer_allocator
branch
from
068f12a to
827a8ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#40